Nostr Web Client

Hello guys. I have some changes to NIP55, but some of them might be breaking changes. Can we discuss them?

1. Change some fields ```pubKey``` to ```pubkey```, just other nips does.

2. When transmitting information, other nips use pubkey, but here npub is used, and npub is changed to pubkey.

3. Add a function ```get_relays``` just like other nostr signer [NIP-07](https://github.com/nostr-protocol/nips/blob/master/07.md) and [NIP-46](https://github.com/nostr-protocol/nips/blob/master/46.md)

You can see the detail from this https://github.com/haorendashu/nips/blob/nip55-fix/55.md

nostr:npub180cvv07tjdrrgpa0j7j7tmnyl2yr6yr7l8j4s3evf6u64th6gkwsyjh6w6 nostr:npub1gcxzte5zlkncx26j68ez60fzkvtkm9e0vrwdcvsjakxf9mu9qewqlfnj5z nostr:npub1w4uswmv6lu9yel005l3qgheysmr7tk9uvwluddznju3nuxalevvs2d0jr5 nostr:npub10td4yrp6cl9kmjp9x5yd7r8pm96a5j07lk5mtj2kw39qf8frpt8qm9x2wl

Reply to this note

Please Login to reply.

Discussion

greenart7c3 1y ago

If you look at the signer provider file in amber there's a version tag I used in amethyst.

I think you should create a version tag in the intents to so we can change this without breaking clients

fiatjaf 1y ago

I'm pretty sure you can update this while being totally backwards-compatible.

DASHU 1y ago

nostr:npub1w4uswmv6lu9yel005l3qgheysmr7tk9uvwluddznju3nuxalevvs2d0jr5 Yes, i also believe that you can update and with backwards-compatible . 🤣

Maybe we can discuss more details in github.

Actually, I have completed the development and tested the version you have implemented. If you decide to make a change, I can assist you in testing both the old and new versions.

greenart7c3 1y ago

Yes I checked it and I believe only 0xchat is not checking if is a hex key or npub

fiatjaf 1y ago

1. I agree "pubKey" is ugly, but this is just cosmetics, right? We can live with it.

2. Same, hex and bech32 are just two ways of encoding the same data. I prefer hex too, and would have been better to not impose bech32 requirements on apps from the getgo. But maybe we can live with it?

3. This should be added, but it would be optional anyway, so apps can't rely on it.

water783 1y ago

This is great tbh; we can ensure backward compatibility.