I don't really get what's going on in there tbh. Are these commits on ExpressJS main?
I understand that this might be a controversial opinion, but I believe that new developers should not contribute to established open source projects. It only makes the lives of open source project managers more difficult.
If a developer cannot understand the basics of full code base, they should not contribute. This practice is essentially turning into spam and is akin to a DDoS attack on the open source community.
Many open source projects are considering going closed source due to this exact reason. People with little to no coding knowledge are literally practicing on main ExpressJS repo. What a nightmare for these project managers.
https://video.nostr.build/84049a473935a18ab66e30c582f7ea7adb1dfb23ff461d1504dac7194a9f0a2f.mp4
Discussion
People going for the lowest hanging fruit and as they don't know shit, they miss the mark and thus only waste the time of the maintainers.
In this case, they propose to change the documentation and probably they suggest to add a linebreak here or a comma there.
Yeah, which is utterly stupid, but then again, from what I remember from other systems, I'd prevent this early on by making sure people who have the permission to create a PR already earned some "merits" in the project or otherwise have proven to add meaningful contributions. Not sure whether github supports that, though.
GitHub doesn't allow a project owner to block PRs. You can spam any public project with PRs. And people use it to file issues where the issue tracker is not public.
Lets improve on that in NIP34 💪
Uh. I see. This is quite an ugly setup then and just begging for abuse. 😬
Dumping some nip34 thoughts:
1) maintainer opt-in feature
2) allow list or WoT based
3) must be clearly communicated to potential contributors in clients
4) could specify rules that could be implemented in a ci environment via a DVM. Eg. Must add or update tests, or must pass standard ci pipelines. A DVM could run the checker against the PR/patch set and respond with a specific comment before the PR gets shown publicly and to the maintainers.