Asking this a bit late, but could someone who is familiar with GitHub advise?
I tried creating a pull request for Damus (my first PR anywhere ever) for haptic/long-press zap amount customizations.
Then I submitted it.
It now shows a message that I am asking to merge 264 commits. Not intended, obviouslyโฆ and hoping it doesnโt mess with other usersโ more proficient submissions.
Am I doing this right ๐
Halp did I break Damus
@jb55 Iโm sorry
#[0]
Dw your PR is separate and wonโt break anything. Worst case, it will be closed.
How did you submit your changes?
Thanks for the reply ๐
I clicked โcreate PRโ then selected a branch (โzapsโ) and after I entered a title and description clicked โsubmitโ
This one
https://github.com/damus-io/damus/pull/668
I would close that PR and try again. Maybe this video can help you.
Hey thanks for the guidance. Closed (and someone shared a comparable PR) and will watch the vid. Pura vida ๐๐ค
Iโm fairly new to git hub, and messed up up PR similarly. it looks like you *requested* to merge the master branch into damus-ioโs zaps branchโฆ
what you want to do is first fork the master branch which will make it your repository Boston-wine/damus
then you want to make a new branch in your version of the repo, so when you submit different prโs you are only submitting one change at a time (one branch at a time)
then when you go to submit back on the damus-io repo, you want to hit โcompare across across forks select your repo as the head repository and then select the branch for that specific change as compare
Thank you!! ๐
I still have much to learn but it feels good to dive in ๐ค
