Replying to Avatar Santos

From 9127eb2e840f90c55e9d116b7fd368cc5fe610d7 Mon Sep 17 00:00:00 2001

From: sant0s12

Date: Fri, 1 Mar 2024 11:42:14 +0100

Subject: [PATCH] Add svelte-french-toast

---

package-lock.json | 23 +++++++++++++++++++++++

package.json | 1 +

2 files changed, 24 insertions(+)

diff --git a/package-lock.json b/package-lock.json

index e86758d..d0b75e5 100644

--- a/package-lock.json

+++ b/package-lock.json

@@ -12,6 +12,7 @@

"lodash-es": "^4.17.21",

"nostr-tools": "^2.1.7",

"p-limit": "^5.0.0",

+ "svelte-french-toast": "^1.2.0",

"svelte-infinite-loading": "^1.3.8",

"svelte-persisted-store": "^0.9.1",

"tailwind-merge": "^2.2.1"

@@ -6098,6 +6099,17 @@

"svelte": "^3.55.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0"

}

},

+ "node_modules/svelte-french-toast": {

+ "version": "1.2.0",

+ "resolved": "https://registry.npmjs.org/svelte-french-toast/-/svelte-french-toast-1.2.0.tgz",

+ "integrity": "sha512-5PW+6RFX3xQPbR44CngYAP1Sd9oCq9P2FOox4FZffzJuZI2mHOB7q5gJBVnOiLF5y3moVGZ7u2bYt7+yPAgcEQ==",

+ "dependencies": {

+ "svelte-writable-derived": "^3.1.0"

+ },

+ "peerDependencies": {

+ "svelte": "^3.57.0 || ^4.0.0"

+ }

+ },

"node_modules/svelte-infinite-loading": {

"version": "1.3.8",

"resolved": "https://registry.npmjs.org/svelte-infinite-loading/-/svelte-infinite-loading-1.3.8.tgz",

@@ -6177,6 +6189,17 @@

}

}

},

+ "node_modules/svelte-writable-derived": {

+ "version": "3.1.0",

+ "resolved": "https://registry.npmjs.org/svelte-writable-derived/-/svelte-writable-derived-3.1.0.tgz",

+ "integrity": "sha512-cTvaVFNIJ036vSDIyPxJYivKC7ZLtcFOPm1Iq6qWBDo1fOHzfk6ZSbwaKrxhjgy52Rbl5IHzRcWgos6Zqn9/rg==",

+ "funding": {

+ "url": "https://ko-fi.com/pixievoltno1"

+ },

+ "peerDependencies": {

+ "svelte": "^3.2.1 || ^4.0.0-next.1"

+ }

+ },

"node_modules/svg.draggable.js": {

"version": "2.2.2",

"resolved": "https://registry.npmjs.org/svg.draggable.js/-/svg.draggable.js-2.2.2.tgz",

diff --git a/package.json b/package.json

index 9eb424c..b01e26c 100644

--- a/package.json

+++ b/package.json

@@ -48,6 +48,7 @@

"lodash-es": "^4.17.21",

"nostr-tools": "^2.1.7",

"p-limit": "^5.0.0",

+ "svelte-french-toast": "^1.2.0",

"svelte-infinite-loading": "^1.3.8",

"svelte-persisted-store": "^0.9.1",

"tailwind-merge": "^2.2.1"

--

libgit2 1.7.2

Nice! Primal doesn't handle the reply very well since it does not display the patch and therefore shows that you are replying to @UNKNOWN. noStrudel seems displays it properly however. Btw great job on the UX on both the cli and the web app, pretty sleek!

Reply to this note

Please Login to reply.

Discussion

Thank you. did you find ngit intuitive or did it take a bit of brain power to understand what the commands would do?

thank you. was it ngit intuitive or did it take some brain power to work out what the commands would do?

Overall quite intuitive, I really like the interactive commands. The only thing that I didn't get at first is that "ngit send" didn't let me send the last commit on main. Are you supposed to make a new branch, add the commits and then send? What I ended up doing is "ngit send HEAD^" and that seemed to work.

Great feedback. If it is not on a feature branch it expects a reference. Ill change it to defaulting to the most recent commit instead of throwing an error.

I have implemented this and it will be in the next minor release.

commit:31c085a584cbd30f71a44a70eaf828c2c8c5f6e3efb7942547edb37cf4a632cf