Avatar
Vitor Pamplona 2y ago

NIP-04 should be discontinued

https://github.com/nostr-protocol/nips/pull/715

Reply to this note

Please Login to reply.

Discussion

Avatar
hodlbod 2y ago

*will be discontinued

Avatar
Duck Nebuchadnezzar 2y ago

I'm glad you guys are out there attacking the hard problems and poking holes in any suggestion.

Avatar
reya 2y ago

Lume will use nip44 by default in the next update 🔥

Avatar
Vitor Pamplona 2y ago

Let's go!

Avatar
Vitor Pamplona 2y ago

FYI, I I am not sure if you noticed, but we are changing the JSON encoding to a bytearray concat for the gift card and the seal.

More info on this PR ( I have to update the nip24 pr)

https://github.com/nostr-protocol/nips/pull/716

Avatar
PABLOF7z 2y ago

Anything in NDK that could make your life easier for it?

Avatar
reya 2y ago

It would be nice if the NDK supported NIP-44 out of the box. 😅

ndk.getSharedKey

ndk.nip44Encrypt

ndk.nip44Decrypt

Avatar
Braydon Fuller 2y ago

What are the details on this comment?

> nip4 is broken cryptography that will expose your private keys. It should never be used.

Avatar
Vitor Pamplona 2y ago

Paul clarified below, but basically somebody could brute force your private key if you have sent a lot of nip04s.

https://github.com/nostr-protocol/nips/pull/715#issuecomment-1675301250

Avatar
Ryley Schaeffer 2y ago

Good to know, thanks.