Carving out the subjective pro/con arguments (meaningful vs. useless,) then ask, is the limit important enough to move to a consensus-level check (i.e. required to be passed to be included in the block)? The argument to remove it because it’s “useless code” bypasses the intent of the code, which should be addressed.
Discussion
The code does what it intends on doing. It filters transactions from your personal mempool. What is the effect of the code on the network?
Nothing.
Because your personal mempool has no effect on what gets mined.
If I'm wrong or you disagree, explain how.
We should remove code from the repo that does nothing in practice.
A consensus level change is a hard fork. You can count me out. I'll lean to sell the fork, but will keep them for a couple months. The winner will probably be clear by then. If the fork coin does not outprice the original in that time frame, it never will.
Code we don’t see as effective sometimes is effective or beneficial for some when the network is operating in the extreme or when concentration occurs.
Even not in the extreme, measuring the effectiveness of something should follow if it does what it is meant to do, and in this case it is meant to stop a node from recognising/relaying a transaction over the limit.
Agreed on the hard fork point.
side note:
modulo is pretty sick. Thanks for making it.
Thanks—a lot of work went into making the modulo key. Being physical it unexpectedly gives positive vibes.
I’d zap you some thanks but I get errors fetching your invoice for some reason.
I’ll think about a response to your response.