Nostr Web Client

i'm not sure if this feature is complete (ie, saving this setting in user's configuration event?) but it works. i have been starting to learn how to work with typescript/react in my new job and this was fairly simple for me except for adding the part where the configuration value is created.

this pull will enable users to completely hide muted replies, and hide notes that referrence mutednpubs notes.

Reply to this note

Please Login to reply.

Discussion

idsera 4mo ago

I always wanted this feature (https://github.com/CodyTseng/jumble/issues/97), someone even opened a Pull request implementing this same thing (https://github.com/CodyTseng/jumble/pull/302) but nostr:npub1syjmjy0dp62dhccq3g97fr87tngvpvzey08llyt6ul58m2zqpzps9wf6wl didn't like it and didn't merge. Maybe this time we have some luck haha.

idsera 4mo ago

Hum, looks like the links was pasted wrong (https://github.com/CodyTseng/jumble/issues/97) and (https://github.com/CodyTseng/jumble/pull/302)

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

the URL parser is failing because you are putting URL valid characters around it, the () always put spaces either side

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

https://github.com/CodyTseng/jumble/issues/97 and https://github.com/CodyTseng/jumble/pull/302

idsera 4mo ago

Yes, but on Primal works ok for example: https://primal.net/e/nevent1qqsdtd2n6568jgthw8j9tjzx3ycyut9q06h6ll34ucwpk2nhxaj89fqencemr

I reported the issue here: https://github.com/CodyTseng/jumble/issues/520

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

i have also had this argument about the validity of () in URLs because wikipedia uses them. this is partly why i don't like pablo, he was totally dismissive of this issue.

just need to know that as a rule you need to space separate URLs. always. brackets are the main reason.

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

there is no logic you can use to determine if close brace after a URL with no space are not part of teh URL. that's not a bug in the code that's a bug in the spec. braces should never have been permitted as valid URL characters but we are so far past the point where it has become common.

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

also, there is still an issue with the code, probably, it still shows replies to muted users, but it hides the preview, you just see the PFP circle and it's a bit confusing. i probably will work on it a bit more so it hides those whole replies as well.

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

i'm gonna try and vibe that extra feature, and also check to see if there is a settings storage event and add this configuration to it so the setting reasserts when you log out and back in

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

meh. i think the user will understand that if they see the empty reply and no quoted reply text that the troll is there, but it won't appear generally unless you start a reply chain after the reply to the troll.

hmm i think i know how to make this work, lemme try

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

it's quite wonky so i might withdraw the PR until i've tested it some more

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

of course i have to see this through to the end. it's almost done now

i have to keep in mind that currently i'm prodding it hard because i'm putting muted notes into the URL which would not happen otherwise. and it hides your own replies to the thread that mentions the muted npub as well.

it's probably enough

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

it has just one last bit where it renders and then hides the muted event in certain situations, but it now mutes not just muted npub replies, it also hides all events that mention mutednpubs.

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

i think this revision completes it. i just didn't think through the issue that idiom in nostr kind 1 feeds they mention everyone in the chain up to the OP. but i think this works now. gonna commit the revision to the PR

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

watching the thread of someone concern trolling one of my favouritenpubs i also spotted another jerk who i also mute who has ingratiated himself into the red ring club who is constantly being a jerk chimed in to defend the asshole who was concern trolling my friend.

ahahaha. i think this is complete now though. no glitchy display of reply frames while the content is hidden. that was also causing the shit to be rendered briefly. i think i've finished the feature.

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

i got the LLM to check if there was somewhere that the code was saving settings but there appears to not be any such thing. there is one ASD event that stores the last time notifications were checked for the highlight, but nothing for settings. so the PR is complete, and it seems to work very nicely.

idsera 4mo ago

Instead of (Display muted notes with a discloser) I would suggest (Hide muted notes and replies to muted notes)