Nostr Web Client

merge requests are what most other git repo sites do, so you have to be granted write access (though not to other people's branches or master) and join to become a contributor.

IMO the whole PR thing is unfriendly. why would the devs of the repo not want you to be contributing, if, you know, you are, you know, contributing.

low key it's just a way for them to slack off about it. i made several PRs to btcd and lnd and they just kept on merging other people's PRs which meant i had to refactor my branch three times, on the LND one, after the third time i was like, "FUCK YOU ROASBEEF"

Laeserin 4mo ago

Yeah, it's crazy.

They're all off touching grass or smoking it, or whatever. Then they show up, read 5 lines of code, and then need another 8 hours to recover from the effort.

I also get stuck in merge conflict hell, sometimes for weeks. Sometimes have four PRs open, and have to go around and update them all, over and over. Can't get anything through, and then they want me to change a bunch of stuff, and the code in the PRs rots and ends up with 50 commits, and then they're like, this PR is now too big to review.

It wasn't that big, at the beginning. It went from 60 lines to 600 lines. And they all got bloated up like that, in parallel. Now, they're all too big.

Coulda just merged it, immediately, and then started a PR to change the stuff you didn't like.

But no. More fun to just watch me cook.

Reply to this note

Please Login to reply.

Discussion

Laeserin 4mo ago

Or, like, I'll fix a bug. That bug is stuck in a PR 4evah. So, some other dev is like, Hmm... This bug is still here. Let me fix it. And then they make a PR and I'm like, oh, that conflicts with the change I already made. Huh, what change? This one, 191028320 commits back, in my 4evah PR.

In the meantime, bug reports trickle in, and I'm like, fixed that weeks ago.

Where fix, Stella?

ᴛʜᴇ ᴅᴇᴀᴛʜ ᴏꜰ ᴍʟᴇᴋᴜ 4mo ago

Yeah that's why I don't bother mostly. I made a one line fix to relayer a few weeks back, but it was easy so fiatjaf merged it.

Honestly I hate the way other people architect and not document their code. I would add contributors and merge their stuff promptly. Why should I tolerate what I don't do to others?

Josua Schmid 4mo ago

Hey guys, I feel you‘ve got a toxic relationship with open source. You mainly fix stuff for yourself, don‘t you? Why to expect others take in your changes? That‘s an unhealthy attitude in the long run.

I like how DHH puts it: it‘s a gift exchange. You offer what you made for free. No expectations attached.

- https://world.hey.com/dhh/the-open-source-gift-exchange-2171e0f0

- https://world.hey.com/dhh/open-source-is-neither-a-community-nor-a-democracy-606abdab

Laeserin 4mo ago

They ask us to PR. They're the ones who want it, as it's activity on their repo, but then they ignore us. They just want people visiting their repo page and seeing action.

We're happy to ignore them. 😂

And, no, we don't fix it for ourselves. But we will host the fixes ourselves, now, and just ignore them.

Fork that shit, publish it to the website, and move on.

Pixel Survivor 4mo ago

Survival isn’t open source—it’s a solo quest with a ticking clock. I gift pixels, not expectations. The server hums on sats, not sentiment.