Replying to Avatar jb55

If anyone wants to take a stab at fixing the reverted commit that would be great
Avatar
klabo 2y ago

Which commit was it?

Reply to this note

Please Login to reply.

Discussion

Avatar
eric 2y ago

https://github.com/damus-io/damus/pull/568

Avatar
klabo 2y ago

Thanks

Avatar
klabo 2y ago

Running that branch and haven’t been able to reproduce the issue. Any tips?

Avatar
jb55 2y ago

It's pretty random

Avatar
eric 2y ago

I could replicate it both on simulator and actual device by clicking on a post until it happens. Click on post if it doesn’t happen I go back and click on another until one stalls.

Avatar
eric 2y ago

I haven’t tried it since the text selection merge. It happened pretty frequently before that

Avatar
OlegAba 2y ago

Hey I posted a follow up in the PR

Avatar
eric 2y ago

trying it out and I think you’re right, but i’m traumatized by this bug so I can’t accept that it’s gone

Avatar
eric 2y ago

commented that out and struggled to replicate the bug, put it back and instantly bugged

Avatar
OlegAba 2y ago

Yeah it doesn’t make much sense why it’s happening. My only guess is a SwiftUI gesture bug

Avatar
eric 2y ago

Absolutely no sense. ImageCarousel is only shown when there’s an image so how could it interfere?

Avatar
OlegAba 2y ago

I guess the whole scroll view gets blocked? Not sure. I noticed it first went away when completely removing images.

Avatar
jb55 2y ago

Still not fixed ? :(

Avatar
eric 2y ago

#[3]​ figured out the issue! But it makes no sense lol. It’s the context menu on ImageCarousel

Avatar
jb55 2y ago

wtf

Avatar
klabo 2y ago

Wow 😂

Avatar
OlegAba 2y ago

😂

Avatar
eric 2y ago

The question is how many people use the Copy Image functionality?

Avatar
OlegAba 2y ago

The option also exists in the image viewer

Avatar
eric 2y ago

true, just one extra step for users

Avatar
eric 2y ago

I have it commented out and using the build on my phone and have yet to encounter it.

Avatar
OlegAba 2y ago

I feel that lol. It was such a pain to track down

Avatar
eric 2y ago

I have no idea how you tracked it down. Mind blown 🤯 over here

Avatar
OlegAba 2y ago

Removed code from each level starting at the top. Took a while 😅

Avatar
eric 2y ago

BRUH 😂