Everyones scenario is different.
keepass (and derivatives) are great offline solutions where proper synching can reasonably support multi device.
Bitwarden is open source and can be SaaS or self hosted.
1password is only SaaS but probably offers the best UI of these mentioned here.
In the case of proton pass, its still rather new, and I dont think it supports attachments yet (something all the above do, which is convenient)
The SaaS solutions (Bitwarden, 1Password) also work well for families that need to share passwords, or where members may lock themself out of their account
Ultimately its important to use _something_ as a start, and find the solution that works best for your circumstances.