Nostr Web Client

#asknostr #khatru nostr:npub180cvv07tjdrrgpa0j7j7tmnyl2yr6yr7l8j4s3evf6u64th6gkwsyjh6w6

I think i found another bug, but need confirmation: https://github.com/fiatjaf/khatru/blob/master/blossom/handlers.go#L260C0-L262C3

the "handleList" method returns a list that is not a valid json. It is missing the commas separating each element on the list. Is it the expected result, or should it be a valid json?

Anthony Accioly 1y ago

Also, apparently khatru may be returning invalid json for the list array:

nostr:nevent1qqsvh0rugardkukscs66unxc6ve7uuwmg0tn95t6hzu96rjqfg7chucpz4mhxue69uhkummnw3ezummcw3ezuer9wchsygplltp6djzea24gehwm93cq9fhppve7l6uj6qjmzn4dd79z6etx2upsgqqqqqqs77vxnh

nostr:nprofile1qqszv6q4uryjzr06xfxxew34wwc5hmjfmfpqn229d72gfegsdn2q3fgpz9mhxue69uhkummnw3ezuamfdejj7qgjwaehxw309ahx7um5wf6k2tnrdakj7qg6waehxw309ac8junpd45kgtnxd9shg6npvchxxmmd9usc5pxf, just to confirm, this should be a proper json array with commas between elements right? Can you check nostr:nprofile1qqsrl7kr5my9n6423nwaktrsq2nwzzenal4e95p9k9826mu294jkv4cpzemhxue69uhhyetvv9ujuurjd9kkzmpwdejhgqg5waehxw309aex2mrp0yhxgctdw4eju6t0qy2hwumn8ghj7un9d3shjtnyv9kh2uewd9hj77ew5us example? (If it needs fixing I rather fix khatru first before releasing the next version of Haven)

Reply to this note

Please Login to reply.

Discussion

hzrd149 1y ago

Yes the /list endpoint should return a valid Jason array of blob descriptors

Anthony Accioly 1y ago

Thank you! nostr:nprofile1qqsrl7kr5my9n6423nwaktrsq2nwzzenal4e95p9k9826mu294jkv4cpzemhxue69uhhyetvv9ujuurjd9kkzmpwdejhgqg5waehxw309aex2mrp0yhxgctdw4eju6t0qy2hwumn8ghj7un9d3shjtnyv9kh2uewd9hj77ew5us. Do you want to do the honours and open a PR against khatru? (Otherwise I'll get to it during the weekend :))

Girino Vey! 1y ago

I have it already on my fork. I'll sync it and open a pull request.

Girino Vey! 1y ago

my pr failed the tests, but they should pass after your PR is accepted.