Nostr Web Client

nostr:npub180cvv07tjdrrgpa0j7j7tmnyl2yr6yr7l8j4s3evf6u64th6gkwsyjh6w6 I'm not convinced the changes on the master branch are being deployed to metadata.nostr.com. In your capacity of CEO of nostr can you check please?

fiatjaf 1y ago

Of course not, it's a manual process.

Also I've forked your repo because you never gave me write access to yours, so there are a bunch of changes there now: https://github.com/fiatjaf/nostr-profile-manager

How can we merge both?

Reply to this note

Please Login to reply.

Discussion

DanConwayDev 1y ago

You had access but branch protection was on, forcing everything to go through a PR. I turned that off now. There seems to be a few linting issues and test failures on your master branch.

We should probably start from your tip, as that's whats in production.

Laeserin 1y ago

Just the tip. Promise.

Laeserin 1y ago

Sorry. 😂

DanConwayDev 1y ago

I have proposed some changes to resync.

https://gitworkshop.dev/repo/nostr-profile-manager/proposal/85dcea65ab18772dab342532015edfa91a3a3586c462f641f5758ecf4f0df845

nostr:nevent1qvzqqqqx2ypzpgqgmmc409hm4xsdd74sf68a2uyf9pwel4g9mfdg8l5244t6x4jdqy88wumn8ghj7mn0wvhxcmmv9uq32amnwvaz7tmjv4kxz7fwv3sk6atn9e5k7tcqyzzae6n94vv8wtdtxsjnyq27m7535w34smzx9ajp746can60phuy2flrnph

fiatjaf 1y ago

I merged it using ngit and deployed it. It worked amazingly.

fiatjaf 1y ago

Oh, so I could have merged my own PRs? I didn't realize that. I remember you saying "branch protection" and assumed it was bureaucracy. Sorry.

DanConwayDev 1y ago

Yes. I guess it still is the bad sort of bureaucracy as every change doesn't need to be peer reviewed in this sort of project.