Also, on reflection, I don't really agree with the characterization "only defends against a narrow set of attacks". To me, it's a broad and significant set of attacks that are defended against with encryption at rest: the most likely way to get your secrets stolen is for someone to get access to your physical hardware (stolen laptop; evil maid attack), or perhaps getting access to backups of your filesystem. True that someone actually taking control remotely is a big risk too, especially on Windows, but that is such a catastrophic failure mode that nothing matters .. not a good excuse to have zero defences imo - people regularly assume some level of security at least on MacOS and Linux and they should be able to, I think. A desktop is not a phone.

Anyway all arguable I guess. But not giving the option or any warning - I don't see a justification of it, really.

Reply to this note

Please Login to reply.

Discussion

Arguably an evil maid knows your keys and at rest, the full disk should be encrypted, not only some mnemonic. The FAQ would be a good place to describe the threat models.

It's not too difficult to provide an option for encrypted mnemonic.

PR are welcome

The justification: we implemented it to have a quick test wallet creation and revovery. And since we kept it as legacy option. Should we remove it completly ? Add password or yubikey decryption ? We work on so many things in parallele...

Right, understood. I think it's enough to just document the choice, though personally I think desktop wallets should always have an encryption option, I do understand that Liana is principally targeting HW signing, right.