Omg finally fixed that thread incompatibility between damus and amethyst/plebstr. All the threads will render properly now. Yay. Pushing new build
Discussion
Just wondering - what was the issue? 😊
It was a misimplementation of nip10. I build the thread by the first non-mention e tag after the root, but it should have been the last:
http://git.jb55.com/damus/commit/68ed3d7796d954633fe693f27bb2533e89876d48.html
Damus only adds 2 e tags: root and reply. It seems amethyst/plebstr adds root and multiple e tags when replying.
Oh gotcha 😊Thanks
You are amazing!
looking forward to the update 💜
This is awesome, thank you.
niiice 🤙🏻💜
very great
Thank you sir!
What was the problem?
Nice. 🤙
🤙
Not sure if you fix this in this build, but the like, repost, comment and zap count doesn’t show in the feed until you open the thread and then it shows the real count. Not sure if you are aware of it.
Yes that would be too much data to pull for all events in your feed. Its a bit cleaner this way. Hopefully we will have some kind of stats NIP I can use instead in the future.
Updated! Thanks! 🤙