Thoughts #[2] ?
Discussion
Actually maybe not, one downside of this is that it makes it harder to count retweets like I do likes... having a separate kind is definitely nice for that...
so maybe it makes sense to keep retweets separate but have the preview optimization for quoted retweets text notes? Will ponder...
why not always show preview for quotes and reposts?
I don't have a good way to do that right now since I don't do fetching for new stuff as they pop in the feed, hence the preview tag optimization thing.
ah yeah i had to make updates to fetch adhoc events when it encounters a repost or quote
Yeah I'm not sure I'll ever do that, would be a huge DoS vector.
Well maybe not too big of an issue on your home feed but stuff, feels wrong to me to do potentially N queries for every entry in your feed.
i'm going to cap the limit at 10 event mentions per post, and not render nested reposts/quotes. so potentially 10 queries to the db plus 1 query to relays for 10 event ids. not ideal but imo its worth the usability it brings.
damus already uses kind 6 for reposts, so I guess your client won't see those. We might want to figure out a common format before we have incompatible retweets.
Yours will look like a single post with an event link on my client atm, no preview.
I like a new kind because it is much more explicit and comes with the preview optimization. Otherwise you are left interpreting the contents of a text post which can be ambiguous between clients.
lol i did a lot of interpretations. will have to watch how you implement it
no it won't but again holding off on new kinds in general. even if kind 6=reposts, i still want to be able to render kind 1 events nicely first. not as a standard, just my personal pref. as long as all the same content is available between clients that should be compatible enough
this is prob true. but right now generating counts is lower on my priority list. i would also say you can extract all the same info just using kind 1 (even if it isn't very streamlined)