Replying to Avatar Pip the WoT guy

websockets do add some latency, but if used in the correct situations (long lived connections and/or where data requests are not predictable before connection), they work beautifully.

Having read a lot of others code, the problem is that is garbage. That is the problem, low quality unreadable crap.
Avatar
hzrd149 5mo ago

What do you mean by garbage? Sending tons of messages by making tons if REQs?

Reply to this note

Please Login to reply.

Discussion

Avatar
Niel Liesmons 5mo ago

+1

What is the to-avoid doing list?

Avatar
Pip the WoT guy 5mo ago

I would say being lazy is a red flag. I'll give an example.

One time my relay crashed because someone sent an event with an ID shorter than 64 characters...

After investigating, I found that the method event.CheckID (go-nostr library) wrongly assumed that IDs had exactly 64 characters.

I opened a PR but fuck sake!

Avatar
Pip the WoT guy 5mo ago

no, that is fine. By garbage I mean a library that forgets to ping, or to pong, which leads to unpredictable disconnections, or again race conditions that make your program panic, or bad handling of cancellations