b8
Swift⚡️ 2y ago

#[0] I received a couple of these notifs as you have explicitly called me out twice and you are one of my followings. And this should be okay.

Reply to this note

Please Login to reply.

Discussion

Avatar
WilliamHodl 2y ago

Why is my name displayed like that? Weeeird.

Avatar
WilliamHodl 2y ago

That's my Zap Contest 🤣😭

b8
Swift⚡️ 2y ago

Or is it? Ill think on this

Avatar
yunginter.net 2y ago

if all 3 of those messages are labeled as “tag” you are essentially just saying a p tag exists

Avatar
yunginter.net 2y ago

I’m also not thrilled that you are using “your name” for the notifications rather than “handle” damus uses “handle” in most places such as listing who’s in a thread.

b8
Swift⚡️ 2y ago

Can you send me 1 sats rq. I wanted to see how your name looks like in a zap notification

Avatar
yunginter.net 2y ago

on the topic of notifications… when someone reacts to a reply of mine, it shows a preview of what I replied too, the expected behavior should be a preview of my text that they liked

Avatar
yunginter.net 2y ago

b8
Swift⚡️ 2y ago

I noticed that too, the abstraction lies is in the EventCache() of Profiles. #[3]​ looks like the display name for the pubkey is returned empty in some cases from the cache. Should we show “Liked by Someone” in such cases? thx

Avatar
jb55 2y ago

Sure

b8
Swift⚡️ 2y ago

This is fixed in the pr:

https://github.com/damus-io/damus/pull/892

Avatar
yunginter.net 2y ago

less concerned with the display name… (although another reason why there should be a “/mention_name”/ in metadata.)

rather the text preview of the note body is rendering your op note

but what was liked is my reply and the preview should show, some, of the body of the note that was actually liked… not a preview of the top level note.