Replying to Avatar CamerišŸ¦ā€šŸ”„

Thanks.

I have a PR open, but pushed code does not reflect my local staging where I have been trying to fix the bug.

I added a log statement and deleted_at was coming always as null.

I was planning on filtering events after fetching from the DB to not impact performance.

I will probably just delete the event from the DB and drop the deleted_at column since itā€™s an anti pattern.
Avatar
Bitcoin Jungle 2y ago

Oh man that was dumb of me šŸ˜¬ should have checked the PRs.

Personally I think actually deleting the row instead of a deleted flag makes the most sense for this scenario.

As a user, if I delete an event, I hope my relays will respect that by purging the data (or at least the content). I probably deleted it because it contains info I donā€™t want out there anymore.

Reply to this note

Please Login to reply.

Discussion

No replies yet.