Deletion events (kind 5)
In the following proposal, I listed a hyperlink wrong and then added an event to delete that one and replaced it with a correct even. Unfortunately, the delete even is displayed as an event, rather than resulting in the deleted event being hidden/removed from the thread.
Here are the two ngit events, that I've deleted, so far:
Note with wrong hyperlink:
First ngit init that went wrong:
nostr:note1lv5m0kvmvc4lmy530r0rfaeyuv04zgp2w9sg2cwaednsdyerzwwsdgzttw
Deletion doesn't seem to work.
No. If any relays are not honouring the deletion and continue to serve the event it willstillb be displayed.
The event should be hidden, or if there are responses, masked by a 'user requested the event be deleted warning'
Yeah, the relays are just refusing to delete. Client will have to suppress it, or it'll drive people nuts.
Happened to me, too.
I tried to delete an old repo of mine, because I wanted my latest repo to be shown on the frontpage, and not grouped.
I tried to remove every single tag (except the `d` tag) from the repo, but I used the default sec=1 account in nak.
Now it somehow shows 7 empty items as the first item, with no metadata.
I think it should be hidden from the UI if there's no metadata in the announcement event. (e.g. =delete)
Yes, I'm part way through a redactor of gitworkshop, which is on pause whilst I finish some better onboarding in ngit. The display of repo events and how they are connected to one another needs improvement. I have some ideas for this but I havnt got around to implementing them yet.
We should prioritise this as its a quick win.
This is implemented in vnext. So much for a quick win! Issues and PRs and events responding to them (status, replies, etch) can be deleted with a tool like delete.nostr.com and gitworkshop will honor the deletion.
If the event is a PR or an Issue and a user has already cached it, it will move into a 'marked as deleted' status. replies, etc will be removed.
If a reply is deleted which has other replies to it, these replies will be shown under the top level thread with a 'missing parent note' heading.
a separate job queue processes each deletion event which trawls through local db entries to remove cached counts of replies and update status accordingly.
cc nostr:npub1elta7cneng3w8p9y4dw633qzdjr4kyvaparuyuttyrx6e8xp7xnq32cume
Very nice.
nostr:npub1c03rad0r6q833vh57kyd3ndu2jry30nkr0wepqfpsm05vq7he25slryrnw was also asking for a delete button so I have one in the menu EventWrapper menu (next to the share and reply buttons under more).
Closing as resolved.
