Please stop prefixing your commits and pull requests with "chore" and "feature".

Reply to this note

Please Login to reply.

Discussion

What don’t you like about prefixed commits?

It generally makes them easier to categorise for things like change logs.

A useful changelog is short, to the point and not just an arbitrary categorization of git log.

Those prefixes are used in Nostream to decide whether the next release is a major, minor or patch release.

Most commit messages in the wild are super vague thus worthless anyways and are of the form:

updated X

fixed Y

If you try to limit your commit summary to 72 characters, this convention wastes some real estate for little gains.

Extremely annoying, doesn't accomplish shit.

I prefer LLVM and Linux approaches that just prefix it with the module or part of code that was changed (e.g. [clang]). In big monorepos it's very useful.

I am confused with chore honestly.

We see a chore as something that doesn't deliver user value, but has to be done: e.g. updates a package version, eliminates an anti-pattern, adds a git hook, etc...

My fav guide on how to write commits. I am the expert.

https://cbea.ms/git-commit/

No

Hahahaha

100% -- I hate that trend, semantic commits or whatever the hell it's called

It’s not a trend. It has a purpose

Conventional commits

Some repos at work have a commit hook that prevents the commit if you don’t add the prefix, very frustrating.

I can’t change my amount here because the invoice has 1000sats attached to it. But there’s a guy who has zapped 21sats. How come?

You have to change the amount in the client.

The invoice is encoded with an amount of 1,000 sats. That amount cannot be changed, a new invoice has to be generated instead.

I’m using Damus, how can I change the invoice?

If you tap and hold the zap button ⚡️ Damus will show a pop up with different amounts. You can tap the amount at the top to change it.

It looks like this:

http://i.ii.md/E9X2Hxh1MV.mov

I agree.

I absolutely prefer branch prefixes (ex. [feature|fix]/foo) and the final merge clearly group and makes obvious what we are talking about.

Git Flow has sane defaults about this:

https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

The only execption I found for the commit prefixes is when a project has specific areas that need to be easily spotted in the logs, ex. multiple themes.

At my last job we were supposed to include time logs in each commit. Awful idea. I logged my time in the ui like a civilized developer.

Time logs? Like how? Aren't commits already timestamped?