Replying to Avatar Keith Mukai

Saturday mornings are for BUILDING!!

"overcat" on Github wrote a @npub17tyke9lkgxd98ruyeul6wt3pj3s9uxzgp9hxu5tsenjmweue6sqq4y3mgl PR to add this overlay for how to adjust the brightness. But it needed a bunch of refactoring so I started digging into it and am now pretty happy with it!

Pretty cool to be collaborating with a completely new contributor who got the ball rolling on a great new quality-of-life improvement!

https://nostr.build/av/18eebee3b75621246d933b7e157a11490a9e2c2f66308f4e79078d17a471b123.mp4

Avatar
Keith Mukai 2y ago

Takes some mental gymnastics, but:

* I submitted a PR to overcat to alter their code

* if accepted, my changes would then become part of overcat's PR to @npub17tyke9lkgxd98ruyeul6wt3pj3s9uxzgp9hxu5tsenjmweue6sqq4y3mgl

* if that PR is accepted, then this UI overlay would be part of our next release.

My PR to overcat:

https://github.com/overcat/seedsigner/pull/1

Reply to this note

Please Login to reply.

Discussion

No replies yet.