Sorry... I forgot about the links from Linkedin. Here they are in normal format
and
Today I had a comment on a code review which left me pretty confused.
I would really appreciate if some of you coders out there (some of which have written books and that :) ) could share your thoughts.
The questions are:
1. Is there a code smell here?
2. Do we really need to make variables out of duplicated strings under ALL circumstances?
I have an example here
The documentation the reviewer presented to back up their argument is here: (I know it's for Go, but should still apply)
They have a compelling case, but from my experience, the closest thing I can come up with in terms of code smells, its the "primitive obsession", but that doesn't quite apply.
Please help?
nostr:npub19mun7qwdyjf7qs3456u8kyxncjn5u2n7klpu4utgy68k4aenzj6synjnft, nostr:npub1l2vyh47mk2p0qlsku7hg0vn29faehy9hy34ygaclpn66ukqp3afqutajft
Discussion
No replies yet.