It looks really good

The "labels" in the UI can be kinda confused by "tagging" addresses, since technically every address has only one label (integer/index), so in some places that explain how it works I would just change the wording of "add labels to the address" but say create a labeled address instead which just means adding 1, 2, 3... etc

But on the UI it looks pretty and it could work as well from the user perspective since the wallet does the job of tracking and displaying anyway, so I see different addresses tracking the same "label" or "tag" could work, should just be easy to recover in case the wallet is restored you don't lose the tagging

Reply to this note

Please Login to reply.

Discussion

Also you say "senders cannot tell a label has been applied" in one of the images but they actually can if they see another address because they all start off equal, they just can't know *which* label has been applied to each address 🙂

so that means the address in the image are wrong also because they look like they are completely different, but `sp1q qffj 92fj ...` would be the same, and after the ` ... ` it needs to differ to represent the ending changes

Was dying for this look kinda feedback man… it was intentional coz I thought they look completely different to human eye…but apparently only the last part is different?

Yep, you can read the BIP again at https://bips.dev/352 and find it says

`It is important to note that an outside observer can easily deduce that each published (Bscan, Bm) pair is owned by the same entity as each published address will have Bscan in common. As such, labels are not meant as a way for Bob to manage separate identities, but rather a way for Bob to determine the source of an incoming payment.`

Yes I read that and assumed like a node/wallet can tell they’re the same key pair…didn’t realise it’s literally visible to the human eye. I’m fixing it.

Damn, this is great. Thanks!

I think the idea is: you can create a scheme/hierarchy that allows for multiple labels from user perspective…