Nostr Web Client

Yeah big time. Might be the menu, gonna look into that here shortly.

Reply to this note

Please Login to reply.

Discussion

yes it's probably due to that commit, probably some onTapGesture change?

yeah menu also uses ontapgesture

Hey any lead on this?

If anyone wants to take a stab at fixing the reverted commit that would be great

Oh just saw that you reverted the menu commit. Is the bug still there? FYI text selection won’t work if the note has a gesture on it (long press for menu).

Works for me (double tap)

You’re right. I was using long press to select. The bug seems be gone after the revert

🙏 been pulling my hair out on this one every which way I try has the same issue

Which commit was it?

https://github.com/damus-io/damus/pull/568

Thanks

Running that branch and haven’t been able to reproduce the issue. Any tips?

It's pretty random

I could replicate it both on simulator and actual device by clicking on a post until it happens. Click on post if it doesn’t happen I go back and click on another until one stalls.

I haven’t tried it since the text selection merge. It happened pretty frequently before that

Hey I posted a follow up in the PR

trying it out and I think you’re right, but i’m traumatized by this bug so I can’t accept that it’s gone

commented that out and struggled to replicate the bug, put it back and instantly bugged

Yeah it doesn’t make much sense why it’s happening. My only guess is a SwiftUI gesture bug

Absolutely no sense. ImageCarousel is only shown when there’s an image so how could it interfere?

I guess the whole scroll view gets blocked? Not sure. I noticed it first went away when completely removing images.

Still not fixed ? :(

#[3] figured out the issue! But it makes no sense lol. It’s the context menu on ImageCarousel

wtf

Wow 😂

😂

The question is how many people use the Copy Image functionality?

The option also exists in the image viewer

true, just one extra step for users

I have it commented out and using the build on my phone and have yet to encounter it.

I feel that lol. It was such a pain to track down

I have no idea how you tracked it down. Mind blown 🤯 over here

Removed code from each level starting at the top. Took a while 😅