Absolutely!

Reply to this note

Please Login to reply.

Discussion

I compiled from master after having a quick scan of the code that touches the nsec, as like others, I don't like entering my nsec.

I'm getting this error.

```

Releasing ngit cli app...

✔ Fetched metadata from Github

ERROR RangeError: Value not in range: 1

#0 _RegExpMatch.group (dart:core-patch/regexp_patch.dart:95)

#1 GithubFetcher.fetch (package:zapstore_cli/commands/publish/fetchers.dart:78)

```

with:

```yaml

ngit:

cli:

identifier: ngit

name: ngit

repository: https://github.com/DanConwayDev/ngit-cli

artifacts:

ngit-aarch64-apple-darwin.tar.gz:

platform: macos-aarch64-darwin

executables: [ngit-aarch64-apple-darwin/ngit]

ngit-x86_64-pc-windows-msvc.zip:

platform: windows

executables: [ngit-x86_64-pc-windows-msvc/ngit]

ngit-x86_64-unknown-linux-gnu.tar.gz:

platform: linux-x86_64

executables: [ngit-aarch64-apple-darwin/ngit]

```

Woah that was fast! It was a bug that I just fixed.

Let me push out a release with some documentation and I'll let you know

It was great to meet you in riga and explore way we could collaborate!

I tried v0.0.4 and encountered the following issues when running `zapstore publish` (built from source):

1. I hit the following error because my terminal wasn't wide enough: `ERROR Bad nsec, or the input was cropped. Try again with a wider terminal.`

2. when the shell was narrow ~20 lines of the shell session got cleared above the invocation of `zapstore publish` after the download completed and before entering the nsec. this didn't happen when I widden my shell.

3. events got signed by the interface failed to move past `Publishing kind 32267...`

Great to meet you too man! Thanks for the feedback, I'll have a closer look at these issues and hopefully add an alternative way of signing

Signing via nip46 would be nice. For me it signed the events but didn't succeed in publishing them. I could try and publish them manually to your relay?

Definitely!

when pasting the event json output from the `zapstore publish` command into nak I realised that the quote marks on the json parameter names weren't being closed. Is this down to how it is rendered or perhaps why publishing failed. Anyway, I just pushed them to relay.zap.store.

I see ngit on the relay but I can't install it, as its kind 32267 lacks "f" tags (platform). That's a bit odd. Mind sharing the yaml snippet you used? Also, sure you were on 0.0.4? Check zapstore -v

I see, the YAML is the issue. Try the following:

```

ngit:

cli:

identifier: ngit

name: ngit

repository: https://github.com/DanConwayDev/ngit-cli

artifacts:

ngit-aarch64-apple-darwin.tar.gz:

platforms: [darwin-arm64]

ngit-x86_64-unknown-linux-gnu.tar.gz:

platforms: [linux-x86_64]

```

Fixed: platforms (they need to follow a specific format, will document later), no need to specify executable because the tarballs have ngit (package name == executable name) at the root

Can you retry with this snippet? You may have to use the env var OVERWRITE=true

Platform is an array and roughly based on `uname -sm`

the zapstore TUI indicates they were published successfully.

will my beloved windows users have to wait?

There is no zapstore cli for windows yet. I have nowhere to build or test.

my beloved windows users will have to wait then :)

I know, the relay will check event validity but not specific tags. I'll add the validation client side

I'm not sure what you mean? were you responding to my message about successfully publication?

Oh nvm. I see it works now!

I don't want to detract from the celebrations on the other thread but it according to the screenshot you posted it installed the first prototype version not the latest (v1.4.3).

Damn you're right. I've tried lots of other package and always pulls the latest release, wth? I'll have a look

When I try that yaml snippet on 0.0.4 I get this:

It correctly pulls 1.4.3. What did you see when publishing? Can you try again?

yes I saw exactly that. Also, I tried publishing again and it hung like before.

in the event it also references the github url of the correct release tar file in the zip

That is so strange. I'll dig deeper

the binary at the url location is correct. see:

```

$ curl -o ./ngit.tar.gz -L -0 https://github.com/DanConwayDev/ngit-cli/releases/download/v1.4.3/ngit-x86_64-unknown-linux-gnu.tar.gz

% Total % Received % Xferd Average Speed Time Time Time Current

Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0

100 8844k 100 8844k 0 0 2511k 0 0:00:03 0:00:03 --:--:-- 3133k

$ tar -xzvf ngit.tar.gz

ngit

$ sudo rm /bin/ngit

$ ngit

bash: /usr/bin/ngit: No such file or directory

$ chmod +x ngit

$ sudo cp ngit /bin/ngit

$ ngit --version

ngit 1.4.3

```

Ugh I know what happened. I have ~/.cargo/bin/ngit too (that one is 0.0.1) - for some reason that one was loaded before in $PATH. But weird that loads the zs version (1.4.3) in other terminal session. So the zapstore cli is working correctly. I'll look at the publishing hanging issue

I wonder whether zapstore should check if the binary already exists in the path and warn the user about the conflict?

Definitely! Will add as issue

I was going to do it for you but couldn't find you nostr git announcement ;-)

Also added as issue 🤣