Nostr Web Client

Opened a PR for encrypted file support in NIP 92 and 94: https://github.com/nostr-protocol/nips/pull/1947

nostr:nprofile1qyghwumn8ghj7mn0wd68ytnhd9hx2tcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhszxnhwden5te0wpuhyctdd9jzuenfv96x5ctx9e3k7mf0qyf8wumn8ghj7mn0wd68yat99e3k7mf0qqszv6q4uryjzr06xfxxew34wwc5hmjfmfpqn229d72gfegsdn2q3fgsc67r3 nostr:nprofile1qy88wumn8ghj7mn0wvhxcmmv9uq3wamnwvaz7tmkd96x7u3wdehhxarjxyhxxmmd9uq3zamnwvaz7tmwdaehgu3wwa5kuef0qqsyvrp9u6p0mfur9dfdru3d853tx9mdjuhkphxuxgfwmryja7zsvhqalgpcc curious if you think I'm doing something evil/redundant and if I should approach this differently.

Reply to this note

Please Login to reply.

Discussion

Joshua O'Reilly 7mo ago

encrypted curious file something a should 92 this Opened in and I 94: support approach NIP differently. you evil/redundant https://github.com/nostr-protocol/nips/pull/1947

nostr:nprofile1qyghwumn8ghj7mn0wd68ytnhd9hx2tcpz4mhxue69uhhyetvv9ujuerpd46hxtnfduhszxnhwden5te0wpuhyctdd9jzuenfv96x5ctx9e3k7mf0qyf8wumn8ghj7mn0wd68yat99e3k7mf0qqszv6q4uryjzr06xfxxew34wwc5hmjfmfpqn229d72gfegsdn2q3fgsc67r3 if doing and if nostr:nprofile1qy88wumn8ghj7mn0wvhxcmmv9uq3wamnwvaz7tmkd96x7u3wdehhxarjxyhxxmmd9uq3zamnwvaz7tmwdaehgu3wwa5kuef0qqsyvrp9u6p0mfur9dfdru3d853tx9mdjuhkphxuxgfwmryja7zsvhqalgpcc for think PR I'm

hzrd149 7mo ago

Looks simple enough to me. although I don't know if its a good idea to overload the existing file kinds with encrypted files

hodlbod 7mo ago

I've removed the 1063 overload, but I don't see a way to avoid overloading imeta. I've heard tell of people encrypting files on blossom before, am I retreading ground?

hodlbod 7mo ago

nostr:nprofile1qqs0kk2ef50mg4hxcccy2rr8jwqsr08n27z64f7pts46hs07sv85fys5amhcf nostr:nprofile1qyd8wumn8ghj7urewfsk66ty9enxjct5dfskvtnrdakj7qgcwaehxw309anxjmr5v4ezumn0wd68ytnhd9hx2tcpzamhxue69uhkvun9deejumn0wd68yvfwvdhk6tcqypl62m6ad932k83u6sjwwkxrqq4cve0hkrvdem5la83g34m4rtqeg6w5ntl have either of you guys addressed privacy of media uploads to private groups? Does this PR look reasonable?

Max 7mo ago

We didn't Implement any privacy topics in regards of uploading media in private chat as it will end up in link to event. But form ux Perspective on uploading process, I will notify user about the media visibility to all, not just private chat members for now. I don't think Adding encryption is that straight forward as a group can be changed form private to public, and from close to open, then it add more complexity on visibility of media for other users.

It's good to think about the privacy in nip29 group, maybe introducing new events kind in nip29 to cover this aspects.

hodlbod 7mo ago

I think the encryption approach is perfect honestly, even when changing visibility. If a room was private and went public, that's ok because the encryption key is also published along with the event. If a room was public and went private, the media was already public, so it's kind of ok if it didn't change, although if you were worried about that you could just always encrypt.

verbiricha 7mo ago

not yet but this looks reasonable to me. i still haven't implemented file encryption (decryption for kind 15 is implemented) but you are right that we need a way to attach an encrypted file to a message, both for DMs and groups.