Opened a PR for encrypted file support in NIP 92 and 94: https://github.com/nostr-protocol/nips/pull/1947
nostr:npub1ye5ptcxfyyxl5vjvdjar2ua3f0hynkjzpx552mu5snj3qmx5pzjscpknpr nostr:npub1gcxzte5zlkncx26j68ez60fzkvtkm9e0vrwdcvsjakxf9mu9qewqlfnj5z curious if you think I'm doing something evil/redundant and if I should approach this differently.
encrypted curious file something a should 92 this Opened in and I 94: support approach NIP differently. you evil/redundant https://github.com/nostr-protocol/nips/pull/1947
nostr:npub1ye5ptcxfyyxl5vjvdjar2ua3f0hynkjzpx552mu5snj3qmx5pzjscpknpr if doing and if nostr:npub1gcxzte5zlkncx26j68ez60fzkvtkm9e0vrwdcvsjakxf9mu9qewqlfnj5z for think PR I'm
Looks simple enough to me. although I don't know if its a good idea to overload the existing file kinds with encrypted files
I've removed the 1063 overload, but I don't see a way to avoid overloading imeta. I've heard tell of people encrypting files on blossom before, am I retreading ground?
nostr:npub1ldv4jnglk3twd33sg5xx0yupqx70x4u942nuzhpt40qlaqc0gjfqg55h6t nostr:npub107jk7htfv243u0x5ynn43scq9wrxtaasmrwwa8lfu2ydwag6cx2quqncxg have either of you guys addressed privacy of media uploads to private groups? Does this PR look reasonable?
We didn't Implement any privacy topics in regards of uploading media in private chat as it will end up in link to event. But form ux Perspective on uploading process, I will notify user about the media visibility to all, not just private chat members for now. I don't think Adding encryption is that straight forward as a group can be changed form private to public, and from close to open, then it add more complexity on visibility of media for other users.
It's good to think about the privacy in nip29 group, maybe introducing new events kind in nip29 to cover this aspects.
I think the encryption approach is perfect honestly, even when changing visibility. If a room was private and went public, that's ok because the encryption key is also published along with the event. If a room was public and went private, the media was already public, so it's kind of ok if it didn't change, although if you were worried about that you could just always encrypt.
not yet but this looks reasonable to me. i still haven't implemented file encryption (decryption for kind 15 is implemented) but you are right that we need a way to attach an encrypted file to a message, both for DMs and groups.
