mainly the /list-keys but IMO a signing device should be even know about bech32 encoding

Reply to this note

Please Login to reply.

Discussion

I was thinking mainly from a user experience point of view as most clients use npub etc, knowing which key is which hex could become a bit of a faff so switching keys in the format theyโ€™re used to would make sense. Easy tweak though ๐Ÿ‘

If the client is built correctly the user will never see the hex format. The device should still show the bech32 npub on the screen though. since that's a lot more use-friendly

I'm sorry to keep talking about this, but its not good to mix hex / bech32. hex should be used for all internal values and bech32 for all user-facing display values. mixing the two in either the internal or UI layer just creates more complexity

All internal on the device just works with hex, ui uses a format function to present in bech32 on the screen. Iโ€™ll amend the commands to use hex only.

nostr:npub1dqepr0g4t3ahvnjtnxazvws4rkqjpxl854n29wcew8wph0fmw90qlsmmgt do you want me to wait until the existing PR is reviewed or raise a commit on the current to tweak this?

Amended the code to only use hex on commands (list key, encrypt, decrypt etc), also updated the config tool to include all new commands and parameters.

Will commit once nostr:npub1dqepr0g4t3ahvnjtnxazvws4rkqjpxl854n29wcew8wph0fmw90qlsmmgt lets me know how I should manage it with the existing PR ๐Ÿ‘

Thanks for the feedback, appreciated.

also another idea I just had, would be really cool for users to be able to set a name on the account

Yeah I did consider this, will add a /set-name command to change the name of a key index in the next release. ๐Ÿ‘