My currently favored setup is KeePassXC on desktop, KeePassDX on mobile, and sync the vault with Syncthing. This is offline but still syncs p2p, works like a charm. But I've also used hosted Bitwarden and Vaultwarden, they're also great. Can't go wrong with either option really.