Nostr Web Client

nostr:npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s Likely you are currently eating a $750 plate of Sushi somewhere in Hong Kong and this is the wrong time to hassle you with a mundane thing like this.. but maybe someone at your team has an idea about this:

We have a user who is using Rizful NWC with Damus ... and he says: I want to see more transactions in my transactions list. So I am demoing the "list_transactions" call that Damus makes to our relay, and I see this incoming request:

{

"method": "list_transactions",

"params": {

"type": "",

"limit": 10,

"offset": 0,

"unpaid": false

}

... This means I think that Damus only wants to see 10 transactions? We actually ignore that and return more, because ten is quite a low number. But.. is this intentional, do you really only want your user to only see the 10 most recent transactions are reported by NWC?

Or am I somehow confused?

thanks

Reply to this note

Please Login to reply.

Discussion

Yüksekten Uçan İsmail 4mo ago

Hiii

Nodii 4mo ago

I'll see If I can find someone that can help you out, meanwhile, you can also write a post on the nwc community discord server: https://discord.gg/gdDqxWG4 ( I know discord is not decentralized, feel free to recomend a better decentralized community building app)

Rizful.com 4mo ago

thanks, just put it on the Discord

Rizful.com 4mo ago

Messing with this more -- for now we're going to hard-code a minimum of 25 transactions, because that seems like the minimum useful number. I don't want to go above that because maybe there is some iOS specific reason why you don't want too much data in the transactions list.

Roland 4mo ago

10 should be fine - the request supports pagination and there is a limit on payload sizes on some relays.

Rizful.com 4mo ago

Yes, I learned that the hard way, about the 64k default limit on strfry relays! The thing is that Damus doesn't seem to do any pagination requests....

Roland 4mo ago

CC @danieldaquino

Roland 4mo ago

nostr:nprofile1qqsgk2lq5zknfqzaweneyukz3fmahm0f4h9lmjjgc6q7ezmzfgfq3fspr4mhxue69uhhyetvv9ujumn0wd68ytnhd9ex2erwv46zu6nsqy28wumn8ghj7un9d3shjtnyv9kh2uewd9hsqqudnj are you able to add pagination?

Rizful.com 4mo ago

Or possibly just default to 50 results, instead of 10? Although there might be a reason you chose 10....

Rizful.com 4mo ago

nostr:npub1rzg96zjavgatsx5ch2vvtq4atatly5rvdwqgjp0utxw45zeznvyqfdkxve Not sure how interested nostr:npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s or anyone from #damus is in this issue, but you (and maybe others) have confirmed that Damus only asks for the last 10 transactions via NWC. Right now we're ignoring that and returning 25. We could return 50, which is probably a more reasonable number, but that goes further down the road of violating the NWC spec. Maybe if you ask someone at Damus directly they might take interest in this?

Rizful.com 4mo ago

Oh it looks like nostr:npub13v47pg9dxjq96an8jfev9znhm0k7ntwtlh9y335paj9kyjsjpznqzzl3l8 might be in charge of this issue.

Daniel D’Aquino 3mo ago

Thank you for bringing this up with us. I did some preliminary investigation around the reasoning applied to the 10 transaction limit. It's not very clear yet if can simply increase the number or if we need to implement extra mechanisms around this, so I created a ticket for our team to further investigate this: https://github.com/damus-io/damus/issues/3213

We are unfortunately a bit backlogged at the moment, so it might be a little while until we get to the bottom of this.

node 4mo ago

Seems like you just asked 🤭