Hey nostr:nprofile1qqsptdw0dn05l5wq9u5tens0r972ltjv337xdglzuga0nlnppp6nzhspr3mhxue69uhkummnw3ezucnfw33k76twv4ezuum0vd5kzmqpzpmhxue69uhkummnw3ezumrpdejq2tqq9d, does lightning-tools requestInvoice() support adding a description?
I tried with the “comment” parameter but the invoice returned had a null description.
https://github.com/getAlby/js-lightning-tools/blob/master/src/lnurl/LightningAddress.ts#L191
Hi, it depends on which lightning address you are paying to. I think most won’t store it in the memo of the invoice. But Alby Does
I’m using bullish@getalby.com for both scenarios. When using lightning-tools and pasting the created invoice into Primal wallet, I don’t see anything. However, when using NWCClient in alby-sdk, I see the description.
Oh! you use the Cashu backend, that’s why
Actually, this address is for a phoenixd backend. The description is set as expected when creating the invoice with NWCClient but not with lightning-tools.
It uses the same code though. That’s weird.
I checked yours against mine and only mine has the description set. Probably we have an issue in the Phoenix backend
https://getalby.com/lnurlp/bullish/callback?amount=1000&comment=hi
https://getalby.com/lnurlp/rolznz/callback?amount=1000&comment=hi
Yeah I don’t see the description on the sender side but I do see it on the receiver side. 🤔
1. Your invoice in Primal
2. My invoice in Primal
3. My payment receipt in Alby Go
I think we store the comment as metadata in Alby Hub too. So even if it’s not set on the invoice it will still show in the transaction list
Hm that’s weird. I tried with nostr:npub1w27mc4aa6m0ufe3xs5z3m6qyr52gc0rglept7vqlwx4xeaf72tasnqz70r and nostr:npub1cm3rpgj7457yjuqnvdalxaauakqu0ndkpkyp5cldkyutpz4xszpsmk96wt too and got the same result — only saw the description on the receiver side.
https://blitz-wallet.com/.well-known/lnurlp/bullish?amount=1000&comment=hi
Yeah, LNURL doesn’t specify to save the comment in the invoice. See https://github.com/lnurl/luds/blob/luds/12.md
But we do it when we can to give more context to the payment
I’m just trying to understand why the invoice that’s created this way (via NWC):
```
const response = await client.makeInvoice({1000, description: "hi"});
```
Allows me to see the description when paying the invoice, but the one that’s created this way does not.
```
const invoice = await ln.requestInvoice({ satoshi: 1000, comment: “hi”});
```
This second method is what I’m using to implement payment for an e-commerce website. Not too much of an issue, but it would be nice if the customer could see the description (e.g. “Order #21shss”) when paying the invoice.
Ah, we check the description hash first rather than the description. Would you like to do a PR to fix the check? https://github.com/getAlby/hub/blob/master/lnclient/phoenixd/phoenixd.go#L286
