Ahh are you saying this patch is only for Primal? Does Primal still need to implement this patch?
And Damus still needs to implement NIP-10? Is that that correct? nostr:npub1zafcms4xya5ap9zr7xxr0jlrtrattwlesytn2s42030lzu0dwlzqpd26k5
see nostr:note1f64ngt2pue70r9c8yxv6uph7llw9fxhay2s90vdyernv7smcdmcquzf9yr
patch is for primal, correct. nostr:npub16c0nh3dnadzqpm76uctf5hqhe2lny344zsmpm6feee9p5rdxaa9q586nvr can confirm if merge has occured.
damus still needs to implement nip-10, correct. see https://github.com/damus-io/damus/issues/2145
I will reply here everyday until this is done. nostr:npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s nostr:npub16c0nh3dnadzqpm76uctf5hqhe2lny344zsmpm6feee9p5rdxaa9q586nvr nostr:npub1sg6plzptd64u62a878hep2kev88swjh3tw00gjsfl8f237lmu63q0uf63m
It will take all of you less than a day. Put down the new features for a sec, please 🙏, and get basic functionality working so we can retain the current set of users.
My excuse is that damus is preserving the old threads that used deprecated nip10, if people forget about that then many old threads will be broken. Maybe it doesn’t matter though.
nostr:npub1yaul8k059377u9lsu67de7y637w4jtgeuwcmh5n7788l6xnlnrgs3tvjmf does your nip-10 approach for damus work, and does it break old threads?
My fix on Primal and what needs to be fixed on Damus are two different things.
You can support reading old threads while support writing new replies using the new recommended part of the NIP-10 spec.
I looked briefly into implementing it in Damus a while back but it seemed like it was a non-trivial refactor requiring a lot of changes so I ended up not doing it.
nostr:npub1xtscya34g58tk0z605fvr788k263gsu6cy9x0mhnm87echrgufzsevkk5s best of both worlds? But the extra work of supporting both might be a pain. I hope for a unified future. Past threads be damned, but if you can keep them that’s cool too.
Old threads are getting nuked from relay wipes either way. It’s worth giving up the fragmented past for a unified future. ✊
Most people aren’t going to switch apps when one is glitching, they’re just going to stop using Nostr altogether & end up calling it glitchy.
Compatibility is key for user retention… for both of you.
GitNestr and Primal are both moving to the new NIP-10 standard and I want all that new user activity to be visible on Damus. I don’t want Damus to be left behind. Let’s stick together. 💜
I just finished this, just writing some tests and will be on testflight soon
